Skip to content

chore: rename bootstrap to merge_repository #8832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
suztomo merged 8 commits into from
Dec 1, 2022
Merged

chore: rename bootstrap to merge_repository #8832

suztomo merged 8 commits into from
Dec 1, 2022

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Nov 22, 2022 •
edited
Loading

We don't intend to bootstrap the monorepo. The script is there to merge a repository into the monorepo in future. Renaming the file to reflect the usage.

@suztomo
Copy link
Member Author

suztomo commented Nov 22, 2022 

+ cp bootstrap.sh monorepo
cp: cannot stat 'bootstrap.sh': No such file or directory

Fixed.

@suztomo suztomo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 22, 2022
@suztomo
Copy link
Member Author

suztomo commented Nov 22, 2022 

+ git clone https://github.com/googleapis/google-cloud-java.git
fatal: destination path 'google-cloud-java' already exists and is not an empty directory.

meltsufin
meltsufin reviewed Nov 22, 2022
View reviewed changes
generation/repos.txt Outdated
@@ -1,132 +1,3 @@
java-accessapproval
google-cloud-java
java-accesscontextmanager
Copy link
Member

@meltsufin meltsufin Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since java-accesscontextmanager and java-aiplatform are both going to be archived, maybe use a different repository? I would consider something like java-logging.

generation/repos.txt Outdated
@@ -1,132 +1,3 @@
java-accessapproval
google-cloud-java
Copy link
Member

@meltsufin meltsufin Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would this work?

Copy link
Member Author

@suztomo suztomo Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you explained that this job is to merge an existing repository into the monorepo, I think one of the input is this monorepo itself.

@suztomo @meltsufin
Update generation/README.md
c20d315 
Co-authored-by: Mike Eltsufin <[email protected]>
@suztomo
Copy link
Member Author

suztomo commented Nov 22, 2022 •
edited
Loading

repo-metadata is missing in google-cloud-java root. I have to do a special treatment for Google-cloud-java.

New history written in 25.01 seconds; now repacking/cleaning...
Repacking your repo and cleaning out old unneeded objects
Completely finished after 67.94 seconds.
+ cp google-cloud-java/.github/.OwlBot.yaml google-cloud-java/.OwlBot.yaml
+ rm google-cloud-java/.github/.OwlBot.lock.yaml
+ rm google-cloud-java/.github/.OwlBot.yaml
+ sed -i.bak /docker/d google-cloud-java/.OwlBot.yaml
+ rm google-cloud-java/.OwlBot.yaml.bak
+ sed -i.bak /image/d google-cloud-java/.OwlBot.yaml
+ rm google-cloud-java/.OwlBot.yaml.bak
+ sed -i.bak 's|owl-bot-staging|owl-bot-staging/google-cloud-java|' google-cloud-java/.OwlBot.yaml
+ rm google-cloud-java/.OwlBot.yaml.bak
++ grep '^.*api_shortname.*' google-cloud-java/.repo-metadata.json
grep: google-cloud-java/.repo-metadata.json: No such file or directory
+ text=

@suztomo
Copy link
Member Author

suztomo commented Nov 24, 2022

Now this.

An error occurred trying to start process '/usr/bin/bash' with working directory '/home/runner/work/google-cloud-java/google-cloud-java/generation/monorepo/google-cloud-java'. No such file or directory

To reference google-cloud-java-merged.

@suztomo
Copy link
Member Author

suztomo commented Dec 1, 2022

@meltsufin PTAL. All checks passed.

@suztomo suztomo requested a review from meltsufin December 1, 2022 16:40
@suztomo suztomo merged commit 0baa8df into main Dec 1, 2022
@suztomo suztomo deleted the rename_bootstrap branch December 1, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meltsufin meltsufin meltsufin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suztomo @meltsufin @yoshi-kokoro